Skip to content

fixing cache timeout setting #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sid88in wants to merge 2 commits into from
Closed

fixing cache timeout setting #210

sid88in wants to merge 2 commits into from

Conversation

@sid88in
Copy link
Contributor

@sid88in sid88in commented Mar 29, 2016

the current v0.8.4 fails if the cache timeout setting on the UI is not provided in edit datasource settings view: http://hostname:port/druiddatasourcemodelview/list/

self.cache_timeout causes the exception. The new logic is as follows:

  1. try to find the cache timeout value from the UI
  2. If not then get the default value in the caravel_config.py
  3. If the value is not defined in both config and the UI then set it to 0.

@sid88in sid88in mentioned this pull request Mar 29, 2016
Closed
@landscape-bot
Copy link

landscape-bot commented Mar 29, 2016

Code Health
Repository health decreased by 0.25% when pulling c8b76f1 on sid88in:fix_attribute_error into d885dd3 on airbnb:master.

@coveralls
Copy link

coveralls commented Mar 29, 2016

Coverage Status

Coverage decreased (-0.1%) to 71.078% when pulling c8b76f1 on sid88in:fix_attribute_error into d885dd3 on airbnb:master.

@landscape-bot
Copy link

landscape-bot commented Mar 29, 2016

Code Health
Code quality remained the same when pulling e04f212 on sid88in:fix_attribute_error into d885dd3 on airbnb:master.

@coveralls
Copy link

coveralls commented Mar 29, 2016

Coverage Status

Coverage decreased (-0.1%) to 71.047% when pulling e04f212 on sid88in:fix_attribute_error into d885dd3 on airbnb:master.

@mistercrunch
Copy link
Member

mistercrunch commented Mar 29, 2016

Mmmh, some of that logic is already here:
https://github.com/sid88in/caravel/blob/fix_attribute_error/caravel/viz.py#L217

What kind of stack trace were you getting?

@sid88in
Copy link
Contributor Author

sid88in commented Mar 29, 2016

@mistercrunch I have added my stack trace here: #207

@mistercrunch
Copy link
Member

mistercrunch commented Apr 4, 2016

It's been addressed in another PR, thanks for the PR though!

This was referenced Jul 5, 2021
Open
Closed
Open
Closed
Open
Open
Open
Closed
graceguo-supercat pushed a commit to graceguo-supercat/superset that referenced this pull request Oct 4, 2021
@kristw
fix: peerDependencies version (apache#210)
4d79dff
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 17, 2021
@kristw @zhaoyongjie
fix: peerDependencies version (apache#210)
321abf4
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 24, 2021
@kristw @zhaoyongjie
fix: peerDependencies version (apache#210)
b201cb1
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 25, 2021
@kristw @zhaoyongjie
fix: peerDependencies version (apache#210)
f9a80c5
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 26, 2021
@kristw @zhaoyongjie
fix: peerDependencies version (apache#210)
13ceb8d
@snyk-bot snyk-bot mentioned this pull request Dec 13, 2021
Open
This was referenced Mar 29, 2022
Open
Closed
This was referenced Mar 29, 2022
Open
Open
Open
Open
Closed
Closed
Open
@m-ajay m-ajay mentioned this pull request Sep 27, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Oct 6, 2022
Open
@m-ajay m-ajay mentioned this pull request Oct 6, 2022
Open
@laxmanraparthi laxmanraparthi mentioned this pull request Jun 28, 2023
Open
@laxmanraparthi laxmanraparthi mentioned this pull request Mar 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sid88in @landscape-bot @coveralls @mistercrunch